Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_lambda_function: Update 'version' and 'qualified_arn' on publish #15020

Merged
merged 1 commit into from
Nov 5, 2020
Merged

r/aws_lambda_function: Update 'version' and 'qualified_arn' on publish #15020

merged 1 commit into from
Nov 5, 2020
+113 −2

Conversation

jeremychase
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #8081

Release note for CHANGELOG:

resource/aws_lambda_function: Update 'version' and 'qualified_arn' on publish of existing function

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSLambdaFunction_enablePublish'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLambdaFunction_enablePublish -timeout 120m
=== RUN   TestAccAWSLambdaFunction_enablePublish
=== PAUSE TestAccAWSLambdaFunction_enablePublish
=== CONT  TestAccAWSLambdaFunction_enablePublish
--- PASS: TestAccAWSLambdaFunction_enablePublish (75.19s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       75.229s
$ make testacc TESTARGS='-run=TestAccAWSLambdaFunction_disablePublish'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLambdaFunction_disablePublish -timeout 120m
=== RUN   TestAccAWSLambdaFunction_disablePublish
=== PAUSE TestAccAWSLambdaFunction_disablePublish
=== CONT  TestAccAWSLambdaFunction_disablePublish
--- PASS: TestAccAWSLambdaFunction_disablePublish (74.15s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       74.195s

@ghost ghost added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/lambda Issues and PRs that pertain to the lambda service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 3, 2020
@jeremychase jeremychase marked this pull request as ready for review September 3, 2020 20:33
@jeremychase jeremychase requested a review from a team September 3, 2020 20:33
@jeremychase
Copy link
Contributor Author

@bflad @gdavison Is there anything I can do to help shepherd this PR through?

@jeremychase
Copy link
Contributor Author

jeremychase commented Nov 1, 2020 •
edited
Loading

The functionality for this is resolved impacted in #15121

The tests may still be useful.

edit: After running the tests I see that 15121 doesn't fully resolve #8081

@jeremychase jeremychase closed this Nov 1, 2020
@gdavison gdavison reopened this Nov 4, 2020
@gdavison gdavison self-assigned this Nov 4, 2020
@gdavison gdavison removed the needs-triage Waiting for first response or review from a maintainer. label Nov 4, 2020
gdavison added a commit that referenced this pull request Nov 5, 2020
@gdavison
Merge pull request #15020 from JeremyChase:b-aws_lambda-update-qualif…
914df7e 
…ied_arn-on-publish
@gdavison gdavison merged commit 97fa230 into hashicorp:master Nov 5, 2020
@gdavison gdavison added this to the v3.14.0 milestone Nov 5, 2020
gdavison added a commit that referenced this pull request Nov 5, 2020
@gdavison
Update CHANGELOG for #15020
faa34d7
@jeremychase
Copy link
Contributor Author

Thanks @gdavison !

@ghost
Copy link

ghost commented Nov 6, 2020

This has been released in version 3.14.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@gdavison gdavison

Labels
service/lambda Issues and PRs that pertain to the lambda service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.14.0
Development

Successfully merging this pull request may close these issues.

aws_lambda_function qualified_arn isn't updated after changing publish to true
2 participants
@jeremychase @gdavison